Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-58310

ThreadPoolTaskExecutor is memory unsafe when task cancellation occurs around the same time an exhaust network response is received

    XMLWordPrintableJSON

Details

    • Fully Compatible
    • ALL
    • v5.3, v5.0, v4.4
    • Service Arch 2021-10-04, Service Arch 2021-12-13, Service Arch 2022-1-10, Service Arch 2022-1-24
    • 20
    • 3

    Description

      cbState->callback is modified without holding ThreadPoolTaskExecutor::_mutex in ThreadPoolTaskExecutor::runCallbackExhaust(). This is memory unsafe because cbState->callback is also modified in the exhaust codepath's RemoteCommandOnReplyFn upon task cancellation. This issue has been observed to cause server crashes when shutting down a replica set monitor due to a partially initialized TaskExecutor::CallbackFn callback being invoked.

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. SERVER-58221 Stress test for ThreadPoolTaskExecutor for concurrency coverage

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-62396 Add a non-deterministic variant for `ThreadPoolTaskExecutor` tests

          • Major - P3 - Major loss of function.
          • Backlog

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-45114 Connect AsyncDBClient exhaust functionality throughout

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              amirsaman.memaripour@mongodb.com Amirsaman Memaripour
              max.hirschhorn@mongodb.com Max Hirschhorn
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: