Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-58338

Return an error if client attempts an OP_QUERY command other than isMaster/hello

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 5.1.0-rc0
    • None
    • None
    • Major Change
    • Query Execution 2021-07-26, QE 2021-08-09
    • 163

    Description

      This is follow-on work to SERVER-58337. The OP_QUERY RPC protocol is deprecated in 5.0, so we can remove support for it in 5.1. As in the other related deprecation and removals (OP_INSERT, OP_KILL_CURSORS, OP_GET_MORE, etc.) we should continue to log a warning and bump the appropriate serverStatus counter prior to returning an error. Also, the error should be user-friendly, meaning that it should indicate that OP_QUERY commands, other than hello and isMaster, are no longer supported, as opposed to being some indecipherable error produced during validation of the incoming network message (e.g. "unknown op code 2004", or something similar).

      Attachments

        Issue Links

          depends on

          Task - A task that needs to be done. SERVER-58337 Log deprecation warning and bump serverStatus counter upon receipt of OP_QUERY command

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-61030 Add authenticate command to allowlist for OP_QUERY

          • Blocker - P1 - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-66806 Add the "getnonce" command to the "allowedOpQueryCommands" list

          • Blocker - P1 - Blocks development and/or testing work, production could not run.
          • Closed

          Task - A task that needs to be done. SERVER-24426 Remove unnecessary command metadata upconvert/downconvert code

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Task - A task that needs to be done. SERVER-58981 Investigate why saslStart/saslContinue commands are sent as OP_QUERY commands

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-59300 Change AsyncDBClient to use OP_MSG for isMaster request rather than OP_QUERY

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              yoonsoo.kim@mongodb.com Yoon Soo Kim
              david.storch@mongodb.com David Storch
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: