Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-58830

GetKMIPRequestParameters' constructor should be explicit

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 5.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • Fully Compatible
    • ALL
    • Security 2021-08-09

      In C++, constructors which accept a single argument can be automatically used to perform implicit type conversions between the type of the argument and the type class itself. This is frequently undesirable, so unless there is a compelling reason to do so, our codebase requires that constructors with a single argument be marked as "explicit".

       

      In kmip_request.h, GetKMIPRequestParameters is defined to be constructable from a std::vector. We should ensure this constructor is marked explicit.

            Assignee:
            erwin.pe@mongodb.com Erwin Pe
            Reporter:
            spencer.jackson@mongodb.com Spencer Jackson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: