Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-59301

Fix set_step_params.js test to match the signature of the waitInHello fail point

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.2 Required
    • Affects Version/s: 4.2.15
    • Component/s: None
    • Fully Compatible
    • ALL
    • Sharding 2021-08-23
    • 130

      Apparently waitInHello fail point signature change made is somewhat incompatible with existing test set_step_params.js. However mind that the test started failing in 2020 a year before this fail point refactoring, so the logic there was not strong anyway.

      At least we need to adjust the test to the fail point change, which may not be a 100% fix but at least should make it better, then we can revisit the race.

      Old signature:
      MONGO_FAIL_POINT_PAUSE_WHILE_SET_OR_INTERRUPTED(opCtx, waitInHello);
      new one:
      boost::optional<Milliseconds> sleepTimeout;
      MONGO_FAIL_POINT_BLOCK(waitInHello, customArgs)

      { sleepTimeout = handleHelloFailPoint(customArgs.getData(), cmdObj); }

      if (MONGO_unlikely(sleepTimeout))

      { sleepForDurationOrUntilShutdown(*sleepTimeout); }

            Assignee:
            andrew.shuvalov@mongodb.com Andrew Shuvalov (Inactive)
            Reporter:
            andrew.shuvalov@mongodb.com Andrew Shuvalov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: