Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-59518

Change query yielding behavior to WT::commit_transaction instead of WT::rollback_transaction

    • Type: Icon: Task Task
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Storage Execution

      The following is how the current code path for yielding works:

      Query yield releases the storage engine resources here. Locked reads will implicitly open a new storage transaction on the next storage access; lock-free reads will explicitly open a new storage transaction in the restore logic here.
      abandonSnapshot() then closes the storage transaction here.
      _txnClose then calls rollback_transaction here.

      One quick and dirty solution to pivot to calling WT::commit_transaction instead of WT::rollback_transaction would be a bool decoration on the opCtx set during the query yield logic. That should get things up and running, to find out if there's a performance issue. Then a better solution could be explored. But maybe there'll be an obvious good way to do it.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            dianna.hohensee@mongodb.com Dianna Hohensee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: