Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-59597

Remove dead code from SBE Scan operator

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: Internal Code
    • Labels:
    • Sprint:
      QE 2021-11-01

      Description

      In sbe::ScanStage, there is some logic for dealing with the case where _coll is nullptr, though it appears to be the case that we always throw an exception before we reach these cases. We should remove this dead code, and similar elsewhere in the file and replace it with a MONGO_UNREACHABLE_TASSERT where appropriate.

      As part of this work we should also see if the analogous code in ix_scan.cpp is dead as well.

        Attachments

          Activity

            People

            Assignee:
            neil.shweky Neil Shweky
            Reporter:
            ian.boros Ian Boros
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated: