Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-59793

Omit tenantId from serverStatus and currentOp metrics during Merge

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 5.2 Required
    • Component/s: None
    • Labels:
      None
    • Backport Requested:
      v5.1
    • Sprint:
      Server Serverless 2021-10-25

      Description

      If a migration's protocol is "shard merge" then the donor donates all data to the recipient, not just one tenant's data. Thus there's no tenantId. Omit it from the replies of the diagnostic commands serverStatus and currentOp for migrations with protocol "shard merge".

      (Until the Recipient Merge Logic project is complete, "shard merge" migrations still use tenantId. We're gradually implementing shard merge to the point where it doesn't need a tenantId. But we can remove tenantId from serverStatus and currentOp now.)

      The code is in reportForCurrentOp() in tenant_migration_donor/recipient_service.h/cpp, and appendInfoForServerStatus() in tenant_migration_access_blocker_registry.cpp and tenant_migration_donor/recipient_access_blocker.cpp.

      Search for "tenantMigrationAccessBlocker" in the jstests/replsets directory and you'll see that most of the work for this ticket may be updating tests. We use the same tests for the old and new migration protocols, so they must expect different currentOp and serverStatus formats depending on the protocol. Let's make a nicely-factored utility for the JS tests to abstract that difference away.

        Attachments

          Activity

            People

            Assignee:
            christopher.caplinger Christopher Caplinger
            Reporter:
            jesse A. Jesse Jiryu Davis
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: