Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-59820

Correct readability regression in FCV constants

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Fix
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Repl 2021-09-20

      We used to explicitly integrate the FCV upgrade/downgrade states inside the enum name.

      The new system omits those details which makes communicating more difficult. The new raw values:

          kFullyDowngradedTo_5_0,
          kUpgradingFrom_5_0_To_5_1,
          kDowngradingFrom_5_1_To_5_0,
          kVersion_5_1,
      

      The new fcv agnostic, synthetic values:

          static constexpr auto kLatest = FeatureCompatibilityVersion::kVersion_5_1;
          static constexpr auto kLastContinuous = FeatureCompatibilityVersion::kFullyDowngradedTo_5_0;
          static constexpr auto kLastLTS = FeatureCompatibilityVersion::kFullyDowngradedTo_5_0;
      

      I propose changing:

      • kVersion_5_1 to kFullyUpgradedTo_5_1
      • kLatest to kFullyUpgradedToLatest
      • kLastContinuous to kFullyDowngradedToLastContinuous
      • kLastLTS to kFullyDowngradedToLastLTS

            Assignee:
            xuerui.fa@mongodb.com Xuerui Fa
            Reporter:
            daniel.gottlieb@mongodb.com Daniel Gottlieb (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: