Simplify $lookup and $unionWith tests to avoid needing manual disposal

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Done
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Currently a bunch of our unit tests for $lookup end with a line calling dispose, like this one.

      This is a nuisance for readers and authors. It's easy to forget, and doesn't really add anything to the test. We should look into having a helper method return a $lookup stage via a unique_ptr with a custom destructor/deleter like Pipeline has or to use a ScopeGuard or something else to make this more automatic and less of a distraction.

            Assignee:
            Henri Nikku
            Reporter:
            Charlie Swanson
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: