Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-60569

Clean up the OpObserver unittest TestFundamentalOnDeleteOutputs

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 5.2.0, 5.1.2
    • None
    • None
    • None
    • Fully Compatible
    • 65

    Description

      In particular, the test claims to exercise passing in different StoreDocOption, but those are not part of the input.

      In theory, that variable was to control whether OplogDeleteEntryArgs.deletedDoc should have a value when calling onDelete. In practice the RetryableOptions is sufficient to express the cases we're interested in. Sharing code between the delete test case inputs and the update test case inputs is probably to blame.

      Attachments

        Activity

          People

            daniel.gottlieb@mongodb.com Daniel Gottlieb (Inactive)
            daniel.gottlieb@mongodb.com Daniel Gottlieb (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: