Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-60585

Update uses of sliceMerge in the codebase to not refer to "slice"

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 5.2.0
    • None
    • None
    • Fully Compatible
    • Server Serverless 2021-10-11, Server Serverless 2021-10-18, Server Serverless 2021-10-25

    Description

      We decided to stop using the term "slice", so we should remove uses of "slice" from the codebase.

      We could instead say "merge" or "tenantMerge", e.g. for the feature flag gSliceMerge we could say gMerge or gTenantMerge.

      $ git grep -i  sliceMerge
      jstests/auth/lib/commands_lib.js:const isSliceMergeEnabled = TestData.setParameters.featureFlagSliceMerge;
      jstests/auth/lib/commands_lib.js:              protocol: isSliceMergeEnabled ? "slice merge" : "multitenant migrations",
      jstests/replsets/libs/tenant_migration_util.js:     * Returns true if feature flag 'featureFlagSliceMerge' is enabled, false otherwise.
      jstests/replsets/libs/tenant_migration_util.js:    function isSliceMergeEnabled(db) {
      jstests/replsets/libs/tenant_migration_util.js:        const flagDoc = admin.runCommand({getParameter: 1, featureFlagSliceMerge: 1});
      jstests/replsets/libs/tenant_migration_util.js:        return flagDoc.hasOwnProperty("featureFlagSliceMerge") &&
      jstests/replsets/libs/tenant_migration_util.js:            flagDoc.featureFlagSliceMerge.value &&
      jstests/replsets/libs/tenant_migration_util.js:                                           flagDoc.featureFlagSliceMerge.fcv) >= 0;
      jstests/replsets/libs/tenant_migration_util.js:        if (isSliceMergeEnabled(db)) {
      jstests/replsets/libs/tenant_migration_util.js:        isSliceMergeEnabled,
      jstests/replsets/slice_merge_enabled.js: * @tags: [requires_fcv_51, featureFlagSliceMerge]
      jstests/replsets/slice_merge_enabled.js:    assert(TenantMigrationUtil.isSliceMergeEnabled(adminDB));
      jstests/replsets/slice_merge_enabled.js:runFeatureFlagMultiversionTest('featureFlagSliceMerge', runTest);
      src/mongo/db/commands/tenant_migration_donor_cmds.cpp:                MigrationProtocolEnum::kSliceMerge) {
      src/mongo/db/commands/tenant_migration_donor_cmds.cpp:                        repl::feature_flags::gSliceMerge.isEnabled(
      src/mongo/db/commands/tenant_migration_donor_cmds.idl:            kSliceMerge: "slice merge"
      src/mongo/db/repl/repl_server_parameters.idl:    featureFlagSliceMerge:
      src/mongo/db/repl/repl_server_parameters.idl:        cpp_varname: feature_flags::gSliceMerge
      src/mongo/tla_plus/SliceMerge/MCSliceMerge.cfg:\* Config file to run the TLC model-checker on SliceMerge.tla.
      src/mongo/tla_plus/SliceMerge/MCSliceMerge.cfg:\* See SliceMerge.tla for instructions.
      src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:---- MODULE MCSliceMerge ----
      src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:\* This module defines MCSliceMerge.tla constants/constraints for model-checking.
      src/mongo/tla_plus/SliceMerge/MCSliceMerge.tla:EXTENDS SliceMerge
      src/mongo/tla_plus/SliceMerge/SliceMerge.tla:----------------------------- MODULE SliceMerge -----------------------------
      src/mongo/tla_plus/SliceMerge/SliceMerge.tla:\* To run the model-checker, first edit the constants in MCSliceMerge.cfg if desired,
      src/mongo/tla_plus/SliceMerge/SliceMerge.tla:\*     ./model-check.sh SliceMerge
      

      Attachments

        Activity

          People

            mathis.bessa@mongodb.com Mathis Bessa
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: