Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-60990

PrimaryOnlyService shouldn't check for conflicting instances when rebuilding instances on stepup

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 5.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • Server Serverless 2021-11-15

      SERVER-60752 made constructInstance take an 'existingInstances' parameter so that services can check if the new instance would conflict with any existing instances.

      However, constructInstance is called in both PrimaryOnlyService::getOrCreateInstance and PrimaryOnlyService::_rebuildInstances. There's no need to check for conflicting instances in _rebuildInstances, so we pass an empty 'existingInstances' vector.

      Instead, we should make a separate method 'checkIfConflictsWithOtherInstances' that is only called on getOrCreateInstance.

            Assignee:
            didier.nadeau@mongodb.com Didier Nadeau
            Reporter:
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: