PrimaryOnlyService shouldn't check for conflicting instances when rebuilding instances on stepup

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 5.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • Server Serverless 2021-11-15
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      SERVER-60752 made constructInstance take an 'existingInstances' parameter so that services can check if the new instance would conflict with any existing instances.

      However, constructInstance is called in both PrimaryOnlyService::getOrCreateInstance and PrimaryOnlyService::_rebuildInstances. There's no need to check for conflicting instances in _rebuildInstances, so we pass an empty 'existingInstances' vector.

      Instead, we should make a separate method 'checkIfConflictsWithOtherInstances' that is only called on getOrCreateInstance.

              Assignee:
              Didier Nadeau
              Reporter:
              Esha Maharishi (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: