Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-61943

OID::init slow due to hex decode refactor

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Server Programmability
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      SERVER-43909 refactored a hex decoding function used by the hot OID::init function. As reported there, this significantly affects the insert_vector benchmark.

      The specific refactor changed from a looping uint8[] fill to a single call returning std::string. Maybe the allocation or inlining slowed things down.

      https://github.com/mongodb/mongo/commit/58828b0ce9556ee9cb38c484d1226663a0dcd993#diff-d240def0294fa927ab59a7098578eaa53d56af8119f018ad1bd5debc276ca6f0L152

            Assignee:
            Unassigned Unassigned
            Reporter:
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: