Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-62193

Improve insert_vector secondary performance

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major - P3
    • Resolution: Unresolved
    • None
    • None
    • None
    • None
    • Replication

    Description

      In SERVER-39950 we merged some redundant code paths between sync tail and initial sync. In doing so we lost some optimizations which affect the insert_vector test performance on secondaries.

      The largest effect is probably the extra copy of the batch here

      https://github.com/10gen/mongo/blob/857e5ff84b57167abcfb875c56a3cda1464de563/src/mongo/db/repl/oplog_batcher.cpp#L296

      But also note this pre-allocation may not be useful after removing that

      https://github.com/10gen/mongo/blob/8c11a9d7c59a156619ba387be14eb584f979442a/src/mongo/db/repl/oplog_batcher.h#L50

      whereas pre-allocation here may be helpful

      https://github.com/10gen/mongo/blob/857e5ff84b57167abcfb875c56a3cda1464de563/src/mongo/db/repl/oplog_batcher.cpp#L160

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-59776 50% regression in single multi-update

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-61843 Figure out what is going on with our insert_vector performance

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-65054 Avoid slow insert batches blocking replication

          • Major - P3 - Major loss of function.
          • Open

          Activity

            People

              backlog-server-repl Backlog - Replication Team
              matthew.russotto@mongodb.com Matthew Russotto
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: