Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-62507

Investigate “TODO” comment in PathLowering::optimize()

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 6.3.0-rc0
    • None
    • None
    • Query Execution
    • Fully Compatible
    • QO 2023-02-06
    • 162

    Description

      There is a “TODO” comment in PathLowering::optimize() that says "Investigate why we crash when this is removed. It should not be needed here."
      Comment is here
      I tried commenting-out the 3 lines of code that the "TODO" comment refers to, and doing so caused a bunch tests to fail in the "jstests/aggregation/abt" folder:

      jstests/aggregation/abt/basic_agg.js
      jstests/aggregation/abt/basic_unwind.js
      jstests/aggregation/abt/chess.js
      jstests/aggregation/abt/filter_order.js
      jstests/aggregation/abt/find_sort.js
      jstests/aggregation/abt/group.js
      jstests/aggregation/abt/index_intersect1.js
      jstests/aggregation/abt/nonselective_index.js
      jstests/aggregation/abt/object_elemMatch.js
      jstests/aggregation/abt/partial_index.js
      jstests/aggregation/abt/sampling.js
      jstests/aggregation/abt/selective_index.js
      jstests/aggregation/abt/sort.js
      jstests/aggregation/abt/sort_project.js
      jstests/aggregation/abt/type_bracket.js
      jstests/aggregation/abt/type_predicate.js
      jstests/aggregation/abt/unionWith.js
      jstests/aggregation/abt/value_elemMatch.js
      

      The goal of this task is to determine who the author of this "TODO" comment is, follow up with them to get context, and then investigate and understand why removing the code referred to by the "TODO" comment causes these tests to fail.

      From there, next steps will be determined to see if the "TODO" comment should be removed and to see if any code changes are needed.

      Attachments

        Activity

          People

            ted.tuckman@mongodb.com Ted Tuckman
            andrew.paroski@mongodb.com Drew Paroski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: