-
Type:
Task
-
Resolution: Fixed
-
Priority:
Major - P3
-
Affects Version/s: None
-
Component/s: None
-
Labels:
-
Query Execution
-
Fully Compatible
-
QO 2023-02-06
-
162
There is a “TODO” comment in PathLowering::optimize() that says "Investigate why we crash when this is removed. It should not be needed here."
Comment is here
I tried commenting-out the 3 lines of code that the "TODO" comment refers to, and doing so caused a bunch tests to fail in the "jstests/aggregation/abt" folder:
jstests/aggregation/abt/basic_agg.js jstests/aggregation/abt/basic_unwind.js jstests/aggregation/abt/chess.js jstests/aggregation/abt/filter_order.js jstests/aggregation/abt/find_sort.js jstests/aggregation/abt/group.js jstests/aggregation/abt/index_intersect1.js jstests/aggregation/abt/nonselective_index.js jstests/aggregation/abt/object_elemMatch.js jstests/aggregation/abt/partial_index.js jstests/aggregation/abt/sampling.js jstests/aggregation/abt/selective_index.js jstests/aggregation/abt/sort.js jstests/aggregation/abt/sort_project.js jstests/aggregation/abt/type_bracket.js jstests/aggregation/abt/type_predicate.js jstests/aggregation/abt/unionWith.js jstests/aggregation/abt/value_elemMatch.js
The goal of this task is to determine who the author of this "TODO" comment is, follow up with them to get context, and then investigate and understand why removing the code referred to by the "TODO" comment causes these tests to fail.
From there, next steps will be determined to see if the "TODO" comment should be removed and to see if any code changes are needed.
- is related to
-
-
- Closed
-