Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-62716

Handle spurious finishWaitingForOneOpTime in WaitForMajorityServiceTest

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 6.0.0-rc0, 5.0.10
    • None
    • Fully Compatible
    • ALL
    • v5.3, v5.0
    • Service Arch 2022-2-21, Service Arch 2022-03-07
    • 18

    Description

      As determined in BF-22420, there is a possibility that WaitForMajorityService will call waitForWriteConcern on a request that has been cancelled but has not been removed from its request collection yet.

      The service uses two background threads: one for processing requests (by waiting for replication) and the other for removing requests whose futures have been cancelled.

      This behavior can manifest if the cancelled request is at the front of the queue and the processing thread wakes up and acquires the mutex after the cancellation thread has marked the request as processed but before it has removed it from the collection.

      While the behavior itself is not a bug, it does cause problems in WaitForMajorityServiceTest where test logic assumes that the request has been handled only once. For example, CancelingEarlierOpTimeRequestDoesNotAffectLaterOpTimeRequests calls finishWaitingOneOpTime twice and assumes that the first request will have been processed after the first call and the second after the second call.

      One way to fix this would be to call getLastOpTimeWaited after finishWaitingOneOpTime and retry when necessary.

      Attachments

        Activity

          People

            matt.diener@mongodb.com Matt Diener
            vojislav.stojkovic@mongodb.com Vojislav Stojkovic
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: