Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-64421

error_codes.py is easy to misuse

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 6.0.0-rc0
    • Build
    • None
    • Fully Compatible
    • ALL

    Description

      I was developing on a branch for a couple weeks, and occasionally ran python3 buildscripts/errorcodes.py -fix SERVER-63397 on my code. That's the wrong syntax, it should be -fix --ticket SERVER-63397. The script silently ignored my mistake, and executed its default algorithm: replacing "0" error codes with the highest existing error code + 1. Of course, that algorithm leads to conflicts with other people using the same algorithm on their own branches, so when it came time to merge, my commit queue job failed in lint_errorcodes.

      error_codes.py should detect misuses like mine.

      Attachments

        Activity

          People

            jesse@mongodb.com A. Jesse Jiryu Davis
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: