Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-65094

Modularize common code between setClusterParameter commands

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 6.1.0-rc0
    • None
    • None
    • None
    • Fully Compatible
    • Security 2022-05-02, Security 2022-06-13, Security 2022-06-27

    Description

      In SERVER-63870, some code was duplicated between setClusterParameter and _configsvrSetClusterParameter. This primarily entails the logic to transform the BSON in the command argument into the on-disk format and validate the server parameter. This code can be modularized into a single method that is shared by both commands, and we must also create a struct to refer the _id and clusterParameterTime fields instead of hardcoding the name directly.

      Additionally, there may be opportunity to move some of the checks on the request itself into a `validateRequest()` method. This needs some more investigation.

      Attachments

        Activity

          People

            varun.ravichandran@mongodb.com Varun Ravichandran
            varun.ravichandran@mongodb.com Varun Ravichandran
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: