Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-65851

Remove concept of is_const_type from idl generator

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Duplicate
    • None
    • None
    • None
    • None

    Description

      In SERVER-65278 we are using the latest clang-tidy which is removing a lot of case where we have a const return type in many declarations. The idl generator has some specific code around this that could be simplified now that we intend to not use const type in the return for types which are not const ref.

      'const_type': 'const ' if cpp_type_info.is_const_type() else '',
      		 
      // to
      		 
      'const_type': 'const ' if '&' in param_type else '',

       

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. SERVER-58110 IDL: getters sometimes have const value return types

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-65278 fix clang-tidy v4 issues and add v4 clang-tidy builder

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              billy.donahue@mongodb.com Billy Donahue
              daniel.moody@mongodb.com Daniel Moody
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: