Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-65851

Remove concept of is_const_type from idl generator

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None

      In SERVER-65278 we are using the latest clang-tidy which is removing a lot of case where we have a const return type in many declarations. The idl generator has some specific code around this that could be simplified now that we intend to not use const type in the return for types which are not const ref.

      'const_type': 'const ' if cpp_type_info.is_const_type() else '',
// to
'const_type': 'const ' if '&' in param_type else '',

       

            Assignee:
            billy.donahue@mongodb.com Billy Donahue
            Reporter:
            daniel.moody@mongodb.com Daniel Moody
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: