Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-67019

Rename StringSet and StringDataSet to clarify they are unordered

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Internal Code
    • None

    Description

      I was just working on a patch and incorrectly assumed that we had no data structure that could support an unordered set of unowned strings (StringData) other than this one: StringData::ComparatorInterface::StringDataUnorderedSet.

      It turns out that `StringDataSet` is the same thing, but without the collator interface virtual method overhead. In my context I never needed to support collation, so this would have been the better choice.

      To improve visibility and discoverability, I would suggest `UnorderedStringSet` and `UnorderedStringDataSet`.

      Attachments

        Activity

          People

            charlie.swanson@mongodb.com Charlie Swanson
            charlie.swanson@mongodb.com Charlie Swanson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: