Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-67425

ServiceStateMachineTest: separate mock and utility types from the fixture

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None
    • None
    • Service Arch 2022-07-11, Service Arch 2022-07-25, Service Arch 2022-08-08, Service Arch 2022-08-22

    Description

      There's a lot of clutter to support these little enums and helper functions and mocks. It makes the fixture's true logic harder to tease out.

      The biggest of these is StepRunner. This should be separated out.

      The ServiceStateMachineTest fixture should just make instances of these types and manipulate these instances. They don't need their definitions inlined into the fixture class.

      ServiceStateMachineTest: give more descriptive names to these while we're at it:

      struct Data

      enum IngressState

      enum IngressMode

      Attachments

        Activity

          People

            alex.li@mongodb.com Alex Li
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: