Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-68720

Safely parse minWireVersion and maxWireVersion in initWireVersion

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 6.2.0-rc0
    • None
    • None
    • Fully Compatible
    • Service Arch 2022-08-22, Service Arch 2022-09-05, Service Arch 2022-09-19, Service Arch 2022-10-03, Service Arch 2022-10-17

    Description

      As discovered in SERVER-68309, the code in initWireVersion performs an unsafe conversion when getting the values for minWireVersion and maxWireVersion from the reply.

      To handle this safely, we should switch to using wire_version::parseWireVersionFromHelloReply.

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. SERVER-68309 Investigate for unsafe narrowing conversions

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              reo.kimura@mongodb.com Reo Kimura
              vojislav.stojkovic@mongodb.com Vojislav Stojkovic
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: