Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-6921

jstests/geo_borders.js has several issues

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Geo
    • Query Integration

      jstests/geo_borders.js has some problems:

      • It seems to expect some operations to generate exceptions, but it isn't coded in such a way that those exceptions or the lack of those exceptions are handled properly. The result is that these tests never detect errors.
      • It seems to think that values at the maximum value it used in creating the 2d index will fail lookups, but they do not fail in these tests; the behavior may have changed since these tests were written, but the tests were not updated to account for this.
      • Several tests check the count of found items, but the test passes if any number higher than zero are found, even though there is an exact number that could be tested against. Changes in the count of elements returned by a find will not be detected, and the number returned today may or may not be the correct number.
      • Tests that say (in the comments) that they are testing that a correct point is returned only test the "y" coordinate.
      • If the tests for (apparently) expected exceptions are recoded to detect whether or not an exception is thrown then some of those tests fail. We need to revisit the assumptions about where exceptions are thrown and make the tests pass when the desired behavior is seen.

            Assignee:
            backlog-query-integration [DO NOT USE] Backlog - Query Integration
            Reporter:
            tad Tad Marshall
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: