Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-69560

change return type of TransactionParticipant::retrieveCompletedOperations() to a pointer

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible
    • Execution Team 2022-09-19

      This function currently returns a non-const reference to the internal vector of operations for a multi-doc transaction. Since the expected usage of this function is to pass along a pointer to the internal operations to the OpObserver methods for committing multi-doc transactions, it would be nice to change the return type of this function from a reference to a pointer.

      Making this change will help avoid accidental copies like the scenarios described in SERVER-69478.

      This is a slight deviation from our code style for function input and outputs.

            Assignee:
            benety.goh@mongodb.com Benety Goh
            Reporter:
            benety.goh@mongodb.com Benety Goh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: