Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-69570

ServiceExecutorSynchronous inefficiencies

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 6.2.0-rc0
    • None
    • None
    • None
    • Fully Compatible
    • Service Arch 2022-09-19, Service Arch 2022-10-03
    • 21

    Description

      The thread_locals are not great (they're slow in dynamic builds).
      There's a deque that's constructed but never used except on worker threads: https://github.com/10gen/mongo/blob/dab0694cd327eb0f7e540de5dee97c69f84ea45d/src/mongo/transport/service_executor_synchronous.cpp#L103

      There's another one that's not used at all.

      The data members could be more cleanly structured to make this complex class more followable.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: