Part of the contract between ShardingDataTransformInstanceMetrics (and its child classes) is that they increment their associated cumulative metrics when certain events happen that the cumulative metrics are interested in tracking. For example, reads during the critical section should increment both the instance metrics counter and the cumulative metrics counter. As seen by the bug that currently exists in those permalinks, our unit test suite does not cover this behavior.

Unit tests should be implemented for all methods in ShardingDataTransformInstanceMetrics and ReshardingMetrics which should update cumulative metrics to be sure that they really do. For example, when a new oplog entry is fetched or when a read comes in during the critical section.

• https://github.com/mongodb/mongo/blob/e884fbf3ac392ca01d080f68beb96328c7ae4c60/src/mongo/db/s/resharding/resharding_metrics_test.cpp#L406
• https://github.com/mongodb/mongo/blob/e884fbf3ac392ca01d080f68beb96328c7ae4c60/src/mongo/db/s/sharding_data_transform_instance_metrics_test.cpp#L233