Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-69775

Rename the _executePhase() method of ShardingDDLCoordinator to reduce the probability of misuses.

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • Sharding EMEA 2022-10-31, Sharding EMEA 2022-11-14, Sharding EMEA 2022-11-28

      The _executePhase() method of ShardingDDLCoordinator is deceiving: it takes in a DDL Phase value and a callable object to implement the handling of such phase, but it does not actually invoke the received functor - instead, it returns a decorated version of it, and the caller of _executePhase() is then responsible to trigger the execution phase when appropriate.

      This misleading name has caused some hard to diagnose issue in the past - and the problem may be fixed with a simple refactoring.

            Assignee:
            paolo.polato@mongodb.com Paolo Polato
            Reporter:
            paolo.polato@mongodb.com Paolo Polato
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: