Use MemoryUsageTracker::withinMemoryLimit() consistently

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 6.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Query Execution
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      MemoryUsageTracker::withinMemoryLimit() wraps

      return _memoryUsageBytes <= static_cast<long long>(_maxAllowedMemoryUsageBytes);
      

      However, there are multiple places in the code where this comparison is done explicitly with different predicates '<', '=>', '>', which can be confusing.

      I propose to replace these comparisons with withinMemoryLimit() or !withinMemoryLimit() whenever possible for clarity and consistency.

            Assignee:
            Projjal Chanda
            Reporter:
            Romans Kasperovics
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: