Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-70202

Investigate calling serverGlobalParams.featureCompatibility.isVersionInitialized() in isEnabled()

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Replication
    • Fully Compatible
    • Repl 2023-05-01

      Currently FeatureFlag::isEnabled() does not check if serverGlobalParams.featureCompatibility.isVersionInitialized(), but in many places throughout the codebase the caller needs to check this (i.e. serverGlobalParams.featureCompatibility.isVersionInitialized() &&
      gFeatureFlagRequireTenantID.isEnabled(serverGlobalParams.featureCompatibility))

      We should investigate if we should always be calling this and can move it into isEnabled()

      Edit: SERVER-66482 created isEnabledUseDefaultFCVWhenUninitialized so we should audit usages of isEnabled and see if we can use isEnabledUseDefaultFCVWhenUninitialized instead.

            Assignee:
            jiawei.yang@mongodb.com Jiawei Yang
            Reporter:
            huayu.ouyang@mongodb.com Huayu Ouyang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: