Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-70895

Consider reordering arguments to async_rpc::sendCommand functions

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.2.0-rc0
    • None
    • None
    • Service Arch
    • Fully Compatible
    • Service Arch 2023-09-04, Service Arch 2023-09-18

    Description

      Existing PrimaryOnlyService implementations have created some existing calling-conventoins for async APIs that take in executors as work-contexts and CancellationTokens for cancellation. Additionally, the server has some best practices around ordering different types of arguments (pointer vs reference vs optional). We should change the argument ordering for sendCommand to match these conventions and expectations. 

      Attachments

        Activity

          People

            erin.mcnulty@mongodb.com Erin McNulty
            george.wangensteen@mongodb.com George Wangensteen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: