Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-71100

Make Session diagnostics logging generic

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • Service Arch
    • Fully Compatible
    • Service Arch 2022-12-26, Service Arch 2022-11-14, Service Arch 2022-11-28, Service Arch 2022-12-12, Service Arch 2023-01-09, Service Arch 2023-01-23, Service Arch 2023-02-06, Service Arch 2023-06-12, Service Arch 2023-06-26, Service Arch 2023-07-10, Service Arch 2023-07-24, Service Arch 2023-08-07, Service Arch 2023-09-04, Service Arch 2023-09-18, Service Arch 2023-10-02

      Design doc: https://docs.google.com/document/d/1Z5KwY7B-ck8pmea0S7y8ak6y7F5FuF3cP1uLMmTx_r8 

      Information provided by the Session to logs is likely to differ between ASIO and gRPC sessions. Instead of systems pulling details from Session in a Session-aware way, these subsystems should be able to call appendBSONForDiagnostics(BSONObjBuilder& bb), or something similar, without having to worry about the underlying Session implementation.

      In the process, we should remove:

      • HostAndPort& remote()
      • HostAndPort& local()
      • SockAddr& remoteAddr(); if possible
      • SockAddr& localAddr(); if possible

      If there is some large project blocking us from removing remoteAddr and localAddr, we should log the corresponding follow-up work (this is a last resort and we reach out to the Security team for help resolving any challenges).

            alex.li@mongodb.com Alex Li
            matt.diener@mongodb.com Matt Diener (Inactive)
            0 Vote for this issue
            4 Start watching this issue