Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-71411

Replace asyncio with explicit timeouts in metrics collection

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.2.0-rc2, 6.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible
    • ALL
    • v6.2

      There is no async code here, so this timeout does not really work as expected: https://github.com/10gen/mongo/blob/74aebe28de1ed67df5b3e6ff3269f0b6d59ef8e1/buildscripts/metrics/tooling_metrics_utils.py#L73

      Thanks max.hirschhorn@mongodb.com for identifying a better way to do this:

      We should just explicitly set timeouts in pymongo code (setting the connection timeout, the socket timeout, and maxTimeMS). Slack thread: https://mongodb.slack.com/archives/CQDQ9R413/p1668615726847349?thread_ts=1667588594.452019&cid=CQDQ9R413

      (You may also want to disable retryable writes which are enabled by default in drivers because you don't want to spend extra time retrying if you get a broken network connection)

       

            Assignee:
            tausif.rahman@mongodb.com Tausif Rahman (Inactive)
            Reporter:
            tausif.rahman@mongodb.com Tausif Rahman (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: