Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-72676

Remove redudant constraint check for journalCommitInterval

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Storage Execution

      journalCommitInterval and storage.journal.commitIntervalMs both add constraints on the parameter in:

      https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/mongod_options_storage.idl#L102

      https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/storage/storage_parameters.idl#L58

      Additionally, there's validation in

      https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/mongod_options.cpp#L436

      I believe at least the check in mongod_options.cpp is redundant. Not sure about the relationship between mongod_options_storage.idl and storage_parameters.idl, but it also looks redundant.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            yujin.kang@mongodb.com Yujin Kang Park
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: