Looks like I accidentally introduced a bug where we not longer collect the artifacts built successfully. This wasn't happening before & the only change was from the old and new get_artifacts function is this line:

https://github.com/10gen/mongo-tooling-metrics/blob/76f9e16e7290d3778aec74ac2a1ab4b65ee6c582/src/mongo_tooling_metrics/lib/sub_metrics.py#L129

vs

https://github.com/10gen/mongo/blob/dc3197e0f68ace45dcfb71b7e31962a41974e636/buildscripts/metrics/metrics_datatypes.py#L110-L128

I shouldn't have used a mutable default arg to begin with, so I am just going to revert to the older but known working solution.

Update: The above did not solve the issue. After further investigation. It was determined that the builddir variable in the ninja file is not where artifacts are stored. The ninja file now generates a new variable called artifact_dir which is where we should search for build artifacts. The above changes were improvements, so we will leave that as is & apply a followup commit for this ticket to use the new artifact_dir.