Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-72810

add "files.insertFinalNewline" to linux-virtual-workstation.code-workspace

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible

      Per the wiki for VSCode setup, it's pretty much required that everyone's producing pedantically valid text files. That is, there should be a newline terminating the last line of every text file we check in.

      So developer VS Code should always be set up with:

          "files.insertFinalNewline": true,
      

      When I wrote that suggestion in the wiki, I deeply wished I had a way to make this a default on every developer's VSCode, but we didn't have that ability until now.

      So can we add this to the .vscode_defaults/linux-virtual-workstation.code-workspace file please?

      PS: Thanks for your work getting something in place to ease the historically complex vscode setup experience for our virtual workstations!

      PPS: the .vscode_defaults/linux-virtual-workstation.code-workspace file itself needs a trailing newline. This may seem pedantic but it's an issue that affects scripting and tooling pipelines etc (see SERVER-55281) that's best avoided. For example:

      $ tail .vscode_defaults/linux-virtual-workstation.code-workspace ; echo "<= Am I alone on this line? =>"
              "extensions": {
                      "recommendations": [
                              "llvm-vs-code-extensions.vscode-clangd",
                              "dbaeumer.vscode-eslint",
                              "ms-python.python",
                              "xaver.clang-format",
                              "notskm.clang-tidy"
                      ]
              }
      }<= Am I alone on this line? =>
      

            Assignee:
            alex.neben@mongodb.com Alex Neben
            Reporter:
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: