Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-74677

Coverity analysis defect 135358: Copy without assign

    • Sharding NYC
    • Fully Compatible

      Copy without assign: src/mongo/db/s/metrics/with_state_management_for_cumulative_metrics.h:44

      This class has a user-defined copy constructor but no user-defined assignment operator. If the copy constructor is necessary to manage owned resources then a corresponding assignment operator is usually required. If an object of this type is assigned memory leaks and/or use-after-free errors may occur. Note that a compiler-generated assignment operator will perform only a bit-wise copy for any fields that do not have their own assignment operators defined. Class has user-written copy constructor but no user-written assignment operator
      /src/mongo/db/s/metrics/with_state_management_for_cumulative_metrics.h:44: COPY_WITHOUT_ASSIGN 135358 Class "mongo::WithStateManagementForCumulativeMetrics<mongo::ShardingDataTransformCumulativeMetrics, mongo::global_index::GlobalIndexMetricsEnumSizeTemplateHelper, mongo::GlobalIndexCoordinatorStateEnumPlaceholder, mongo::global_index::GlobalIndexClonerStateEnum>" has a user-written copy constructor "mongo::WithStateManagementForCumulativeMetrics<mongo::ShardingDataTransformCumulativeMetrics, mongo::global_index::GlobalIndexMetricsEnumSizeTemplateHelper, mongo::GlobalIndexCoordinatorStateEnumPlaceholder, mongo::global_index::GlobalIndexClonerStateEnum>::WithStateManagementForCumulativeMetrics<mongo::WithStateManagementForCumulativeMetrics<mongo::ShardingDataTransformCumulativeMetrics, mongo::global_index::GlobalIndexMetricsEnumSizeTemplateHelper, mongo::GlobalIndexCoordinatorStateEnumPlaceholder, mongo::global_index::GlobalIndexClonerStateEnum> >(mongo::WithStateManagementForCumulativeMetrics<mongo::ShardingDataTransformCumulativeMetrics, mongo::global_index::GlobalIndexMetricsEnumSizeTemplateHelper, mongo::GlobalIndexCoordinatorStateEnumPlaceholder, mongo::global_index::GlobalIndexClonerStateEnum> &&)" but no corresponding user-written assignment operator.
      /src/mongo/db/s/metrics/with_state_management_for_cumulative_metrics.h:50: COPY_WITHOUT_ASSIGN 135358 User-written copy constructor.

            Assignee:
            brett.nawrocki@mongodb.com Brett Nawrocki
            Reporter:
            xgen-internal-coverity Coverity Collector User
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: