Do not use const_cast in sdamServerSelector::_getCandidateServers()

XMLWordPrintableJSON

    • Sharding NYC
    • Fully Compatible
    • Sharding NYC 2023-07-24, Sharding NYC 2023-08-07
    • 2
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The server_selector uses a const_cast to update the passed in criteria in `sdamServerSelector::_getCandidateServers`. const_cast is not great to use because it is modifying a const reference that should not be modified. Right now this does not cause a bug, and is more of a code cleanup ticket.

              Assignee:
              Kruti Shah
              Reporter:
              Wenqin Ye
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: