Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-76472

Add -Wno-psabi to disable ABI warning on ARM64

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.1.0-rc0
    • None
    • None
    • None
    • Server Development Platform
    • Fully Compatible

    Description

      There are spurious warnings about ABI compat on ARM64 builds. We can suppress this noise by passing -Wno-psabi since we do not maintain C++ ABI compat.

      Details
      https://gcc.gnu.org/gcc-7/changes.html:

      On ARM targets (arm***), a bug introduced in GCC 5 that affects conformance to the procedure call standard (AAPCS) has been fixed. The bug affects some C++ code where class objects are passed by value to functions and could result in incorrect or inconsistent code being generated. This is an ABI change. If the option -Wpsabi is enabled (on by default) the compiler will emit a diagnostic note for code that might be affected.

      Log:

      [2023/04/24 18:04:58.078] src/mongo/util/summation.h: In member function 'mongo::DoubleDouble mongo::DoubleDoubleSummation::getDoubleDouble() const':
      [2023/04/24 18:04:58.078] src/mongo/util/summation.h:94:42: note: parameter passing for argument of type 'std::pair<double, double>' when C++17 is enabled changed to match C++14 in GCC 10.1
      [2023/04/24 18:04:58.078]    94 |     DoubleDouble getDoubleDouble() const {
      [2023/04/24 18:04:58.078]       |       
      

      References:
      https://gcc.gnu.org/legacy-ml/gcc/2017-05/msg00073.html

      Attachments

        Activity

          People

            daniel.moody@mongodb.com Daniel Moody
            mark.benvenuto@mongodb.com Mark Benvenuto
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: