Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-77399

Remove preallocateSnapshotForOplogRead()

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.1.0-rc0
    • None
    • None
    • None
    • Fully Compatible
    • Execution Team 2023-06-12, Execution EMEA Team 2023-06-26, Execution EMEA Team 2023-07-10

    Description

      Currently we need to preallocate a snapshot differently if we are reading from the oplog or not.

      When we call preallocateSnapshotForOplogRead() we set the _isOplogReader flag in the WiredTigerRecoveryUnit, which is used when opening a snapshot and then when getting the oplog visibility TS (which is called from here, only when reading from the oplog).

      We should remove this logic and always assume we could be reading from the oplog. For that we'd just need to always set _oplogVisibleTs (when ReadSource is kNoTimestamp), that cost would be an atomic word read.

      Attachments

        Activity

          People

            daniel.gomezferro@mongodb.com Daniel Gomez Ferro
            daniel.gomezferro@mongodb.com Daniel Gomez Ferro
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: