Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-77500

update_index_data should use btree_set instead of std::set

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.1.0-rc0, 7.0.0-rc3
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Fully Compatible
    • v7.0
    • 105

      update_index_data uses std::set for canonicalPaths and pathComponents, and both of these sets are iterated over quite a bit. The cost of iterating over a std::set's rbtree is not cheap, and can be improved by using absl::btree_set instead.

      boost::flat_set was also evaluated, but had worse performance numbers overall compared to btree_set.

            Assignee:
            colin.stolley@mongodb.com Colin Stolley
            Reporter:
            colin.stolley@mongodb.com Colin Stolley
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: