Make LDAP connections take ownership of LDAPConnectionOptions

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Won't Do
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Security 2023-07-24, Security 2023-08-07
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      Currently, LDAPConnectionOptions gets copied numerous times as it is derived from the default options and propagated into a particular connection. The propagation mostly involves pass by reference into various local variables, which makes it challenging to determine ownership. It also contrasts with the updated approach used for LDAPBindOptions, which involves constructing a unique_ptr in the LDAPRunner and moving it into the eventual LDAPConnection.

      Adopting a similar approach for LDAPConnectionOptions would help make the code clearer and easier to follow and minimize risk of ownership/lifetime bugs seen in the past.

            Assignee:
            Varun Ravichandran
            Reporter:
            Varun Ravichandran
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: