ParsedDistinct::asAggregationCommand() should return an AggregationRequest, not a BSONObj

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Query Optimization
    • 200
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Since a view is defined by an aggregation pipeline, we convert any count, distinct, or find command request to an equivalent aggregation command.

      For the distinct command, this is accomplished with ParsedDistinct::asAggregationCommand(). Currently this returns a BSONObj, which we almost always parse immediately into an AggregationRequest. For performance and simplicity, we should change these methods to return a StatusWith<AggregationRequest> directly.

      Also, if the caller always uses uassertStatusOK on the result, we can further simplify by returning AggregationRequest directly, and throwing an exception in the error case.

              Assignee:
              Sander Verwimp
              Reporter:
              David Percy (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: