Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-78875

ParsedDistinct::asAggregationCommand() should return an AggregationRequest, not a BSONObj

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Query Optimization

      Since a view is defined by an aggregation pipeline, we convert any count, distinct, or find command request to an equivalent aggregation command.

      For the distinct command, this is accomplished with ParsedDistinct::asAggregationCommand(). Currently this returns a BSONObj, which we almost always parse immediately into an AggregationRequest. For performance and simplicity, we should change these methods to return a StatusWith<AggregationRequest> directly.

      Also, if the caller always uses uassertStatusOK on the result, we can further simplify by returning AggregationRequest directly, and throwing an exception in the error case.

            Assignee:
            backlog-query-optimization [DO NOT USE] Backlog - Query Optimization
            Reporter:
            david.percy@mongodb.com David Percy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: