Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-79122

Support building the GDB pretty printer tests using ninja

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.2.0-rc0
    • None
    • Build
    • None
    • Server Development Platform
    • Fully Compatible

    Description

      Only supporting building the pretty_printer_test_launcher*.py scripts using SCons is inconvenient for local development because Server engineers are primarily compiling using ninja and the icecream cluster. The changes from b334631 as part of SERVER-77339 are misleading because the ninja target for install-pretty-printer-tests is defined but does not work as expected. Instead the build/install/pretty_printer_tests.txt file is left empty.

      Moreover, while the install-pretty-printer-tests ninja target will generate a build/opt/mongo/util/pretty_printer_test_launcher_pretty_printer_test.py file, it won't install the file into the build/install/ directory. The install-pretty-printer-tests ninja target won't even generate the build/opt/mongo/db/concurrency/pretty_printer_test_launcher_lock_gdb_test.py or build/opt/mongo/db/query/optimizer/pretty_printer_test_launcher_optimizer_gdb_test.py files and so it isn't possible to build all of the GDB pretty printers testing code without running SCons.

      We should make it simple for Server engineers to build and run the GDB pretty printer tests locally.

      Attachments

        Activity

          People

            trevor.guidry@mongodb.com Trevor Guidry
            max.hirschhorn@mongodb.com Max Hirschhorn
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: