Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-79335

Audit gFeatureFlagColumnstoreIndexes

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.0.3
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • Query Execution
    • Fully Compatible
    • QE 2023-10-02

      This ticket has been split from an audit of all Query 7.0 feature flags. This ticket is a request to audit gFeatureFlagColumnstoreIndexes.

      Intial sync can temporarily reset the fcv value to uninitialized and sets the new value afterwards. This can cause call sites trying to inspect the fcv value to hit this invariant. We need to audit feature flag usage and determine which should do one of the following:

      • It can never be called when initial sync is running. So do nothing. Note that this can be tricky to prove as we once thought the catalog cache loader can never be run while initial sync is happening but it can.
      • It is safe to ignore fcv version so use isEnabledAndIgnoreFCVUnsafe instead
      • It is safe to turn off the feature anytime (even if feature flag is actually on) so use isEnabledUseDefaultFCVWhenUninitialized instead.
      • Special logic is needed if fcv is not initialized

            ian.boros@mongodb.com Ian Boros
            randolph@mongodb.com Randolph Tan
            0 Vote for this issue
            5 Start watching this issue