Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-79356

Refactor AutoGet* Options to use designated intialisers

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None
    • None
    • Storage Execution
    • Execution EMEA Team 2023-09-04, Execution EMEA Team 2023-10-02

    Description

      We follow a pattern where the OptionsBase struct contains seemingly private members (e.g. _viewMode) with setter functions which emulate designated initialisers.

      e.g. to initialise with a viewmode and a deadline.

      AutoGetCollection::Options{}.viewMode(auto_get_collection::ViewMode::kViewsPermitted).deadline(someDeadline);

      It is confusing because those members are not really private, and are being accessed when using the options. Now that we have designated initialisers we could improve how we initialise options.

      Attachments

        Activity

          People

            yujin.kang@mongodb.com Yujin Kang Park
            yujin.kang@mongodb.com Yujin Kang Park
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: