Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-79458

Remove "why" parameter from WriteOp::cancelWrites and unused BatchWriteOp::_cancelBatches method

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 7.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • Repl 2023-08-07, Repl 2023-08-21

      In SERVER-77269 we removed some logic from BatchWriteOp::cancelWrites that had no effect. Now that it is removed, the why parameter is no longer used, so we should just remove it and update the call sites to stop passing a value.

      https://github.com/mongodb/mongo/blob/5f1b3024bf6e1d2f79e0c934a694b92929370c16/src/mongo/s/write_ops/write_op.cpp#L251

      Also, the BatchWriteOp::_cancelBatches method which calls this method is not used so we can remove it as well.

            Assignee:
            kaitlin.mahar@mongodb.com Kaitlin Mahar
            Reporter:
            kaitlin.mahar@mongodb.com Kaitlin Mahar
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: