WiredTigerRecordStore::doUpdateRecord breaks RecordStore::updateRecord contract

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • RSS Sydney
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      The RecordStore provides two methods to update a record, full update (updateRecord) and incremental update (updateWithDamages). However, WiredTigerRecordStore::doUpdateRecord under some conditions, might try to do an incremental update. This breaks the expectations of RecordStore::updateRecord callers.

      I.e. updateStage has its own logic to decide whether to compute damages and do incremental updates or full updates.

      Maybe we should be push this logic outside WiredTigerRecordStore::doUpdateRecord, and call RecordStore::updateWithDamages as required.

       

            Assignee:
            Unassigned
            Reporter:
            Yujin Kang Park
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: