Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-80345

BucketVersion should not use magic numbers

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 7.2.0-rc0
    • None
    • None
    • None
    • Storage Execution NAMER
    • Fully Compatible
    • Execution NAMR Team 2023-09-18

    Description

      The time-series buckets have a control.version field that is currently either a 1 or 2 value. It is difficult to comprehend what the versions mean as integers as opposed to the descriptive names in timeseries_constants.h:

      • kTimeseriesControlUncompressedVersion
      • kTimeseriesControlCompressedVersion

       

      Replace all magic numbers with these descriptive names.

      A few examples:

      • bucket_unpacker.h
      • validate_adaptor.cpp
      • bucket_unpacker_test.cpp

      Attachments

        Activity

          People

            matt.kneiser@mongodb.com Matt Kneiser
            matt.kneiser@mongodb.com Matt Kneiser
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: