Refactor appendFieldsForStartTransaction

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Cluster Scalability
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      This code re-checks that the input cmdObj is in sync with the parsed readConcernArgs (i.e., that we didn't swap majority for local or snapshot somewhere along the command execution path). This is very error prone and wasteful and a better architecture would be if cmdObj was not allowed to contain any read concern arguments so that we can just append the ones passed to the function.

      https://github.com/10gen/mongo/blob/e3d867d884892e7e59c50704e3eee1f81c55ccd5/src/mongo/s/transaction_router.h#L759

              Assignee:
              [DO NOT USE] Backlog - Cluster Scalability
              Reporter:
              Randolph Tan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: