Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-81120

Assert on Status portion of StatusWith in gRPC unit tests

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Works as Designed
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None
    • None
    • Service Arch 2023-09-18, Service Arch 2023-10-02
    • 11

    Description

      There are many instances in the gRPC unit tests where ASSERT_OK is used with StatusWith<T> objects. While this functionally works to assert that these are in fact OK, the exception that is thrown when the assertion fails does not print useful information about the error that was experienced. We should update the gRPC unit tests to invoke .getStatus() when asserting on StatusWith objects so that future BFs are more easily diagnose-able.

      See BF-29927 for examples of poor log messages.

      Attachments

        Activity

          People

            patrick.freed@mongodb.com Patrick Freed
            patrick.freed@mongodb.com Patrick Freed
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: